Fix: handled status filtering #106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If property object has anything which leads to know whether match to be performed via strict regex (adding ^ and $) or simple regex will help to remove the hard coded match over field |
dziraf
requested changes
May 4, 2023
| @@ -15,8 +15,13 @@ export const convertFilter = (filter) => { | |||
| const { property, value } = filterProperty | |||
| switch (property.type()) { | |||
| case 'string': | |||
| let regexPattern = ''; | |||
| if (property.name() === 'status') | |||
There was a problem hiding this comment.
This won't do, the only way I see it works is if you somehow check whether the property is enum/has availableValues
There was a problem hiding this comment.
@dziraf Can you share me a reference? It would be very helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #105